Skip to content

fix(pr-title): Remove unecessary if always conditions #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chris3ware merged 3 commits into from
Mar 5, 2025
+5 −4
Merged

fix(pr-title): Remove unecessary if always conditions #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa57be5
fix(pr-title): Remove `if: always()` from success steps
chris3ware Mar 5, 2025
acae697
fix(checks): Remove `edited` pull request event type
chris3ware Mar 5, 2025
7e0cbd5
fix(pr-title): Remove synchronize event type
chris3ware Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pr-title.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Validate PR title

on:
pull_request:
types: [opened, edited, reopened, synchronize]
types: [opened, edited, reopened]
branches: [main]
workflow_call: {}

Expand Down Expand Up @@ -119,15 +119,15 @@ jobs:

- name: Delete PR comment on resolution
# Delete comment if the error message is null or the PR title is the correct length
if: ${{ always() && steps.validate-pr-title.outputs.error_message == null }}
if: ${{ steps.validate-pr-title.outputs.error_message == null }}
uses: marocchino/sticky-pull-request-comment@331f8f5b4215f0445d3c07b4967662a32a2d3e31 # v2.9.0
with:
header: pr-title-error
delete: true

- name: Summary with valid title
# A length check is not required here because the validate-pr-title step will only run if the title is less than or equal to the max length
if: ${{ always() && steps.validate-pr-title.outputs.error_message == null }}
if: ${{ steps.validate-pr-title.outputs.error_message == null }}
run: |
echo "### :white_check_mark: Pull Request title is valid" >> $GITHUB_STEP_SUMMARY
echo "The pull request title conforms to the conventional commit specification." >> $GITHUB_STEP_SUMMARY
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/wait-for-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Checks

on:
pull_request:
types: [opened, edited, reopened, synchronize]
types: [opened, reopened, synchronize]
branches: [main]
workflow_call: {}

Expand Down Expand Up @@ -34,6 +34,7 @@ jobs:
# Approve PR raised by 3ware-release[bot] to upgrade trunk on trunk branches
# after all checks have passed.
auto-approve-pr:
# TODO: Add terraform app to actor, maybe project/** to branch as well
if: ${{ github.actor == '3ware-release[bot]' && github.head_ref == 'trunk-io/update-trunk' }}
needs: [enforce-all-checks]
runs-on: ubuntu-latest
Expand Down