Fix blank run terminal and invisible dark-theme hover - #66
Merged
Conversation
The terminal-core refactor (#42) moved xterm setup into useXterm but dropped the attach's onData handler in the run terminal view: output frames arrived on the socket and were discarded, so the agent TUI pane stayed blank forever. Wire PTY output back into xterm and pin the contract with a regression test. The theme refresh (#46) set the dark --accent to #0b1120, the same color as the sidebar and secondary surfaces, so every hover:bg-accent state became invisible. Raise it to #242e40 so hover reads again. It also used the landing mint #6ee7d6 as --primary, which glares on the dark surfaces; dim interactive fills to #5cb7aa (same hue, lower lightness and chroma) and keep the landing page's brighter mint for itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blank agent TUI on the run Terminal tab
The terminal-core refactor (#42) moved xterm setup into
useXterm, but the run terminal view lost itsonDatahandler in the move: the attach socket delivered the scrollback replay and live PTY frames, and the view dropped every one of them. The pane stayed blank while the header said "Attached".Verified end to end against the live server on moss: the socket carried a 43 KB replay while the pane showed 36 empty rows. With the fix the agent TUI renders on open.
web/src/routes/terminal/index.tsx: wireonDataback toterminal.write.web/src/routes/terminal/terminal.test.tsx: regression test that a binary frame lands in xterm; fails on main, passes here.The run-shell dock, board dock, and master terminal already routed their own
onDataand were unaffected.Dark theme: invisible hover, glaring teal
The theme refresh (#46) set dark
--accentto#0b1120- the same color as the sidebar, secondary, and muted surfaces - so everyhover:bg-accentstate painted the background with itself. It also promoted the landing page's mint#6ee7d6straight to--primary, which glares on the near-black surfaces.--accent→#242e40: a raised steel surface, visibly above the bars it hovers on.--primary/--ring→#5cb7aa: same hue, dialed down from L 0.85/C 0.11 to L 0.72/C 0.09. Still 8:1 contrast against the dark text on filled buttons.docs/styles.mdupdated to match.Checks
bun run typecheck,bun run test(554 pass)make fmt-check vet lint public-auditcleanmake test: two pre-existing environment-sensitive failures (selfupdateunder umask 0002,localgwwith a locally installed desktop app) fail identically on unmodified main; not touched by this change.