feat: workspace image repointing, dashboard origin sync, onboarding fix - #72
Merged
Conversation
…mmits The run checkout, .git included, is agent-writable, and CommitAll ran git with whatever config the agent left there: a pre-commit hook, fsmonitor, or a clean filter selected by a planted .gitattributes ran as the server user on the host. Server-side commits now point hooks at an empty path, disable fsmonitor, read attributes from the empty tree, and drop .git/info/attributes, which has no override.
Workspaces pinned their standard image at creation and nothing could change it, so a server upgrade left every existing workspace running the old image - and its old tooling - forever. A new admin-only workspace.image method reads or sets the pinned ref, the CLI takes --image on workspace settings, and Manage workspaces shows each workspace's image with a one-click update when the server's standard image is newer.
Keeping the server's base branch current meant installing the sync daemon with --sync-origin or pushing by hand; the GUI had no sync affordance at all. A new repo.sync local-gateway verb fetches origin and fast-forwards the server's base branch from it, never forced and never touching the local branch or working tree, and the Settings page gains a Sync from origin button that runs it once, on demand.
The onboarded flag lives in localStorage, but aether gui binds an ephemeral port, so the origin - and the flag - changed on every launch and hydration redirected a fully linked machine back into the wizard each time. A gateway whose link.status answers linked now counts as onboarded before the redirect decision.
update.apply tests ran the real desktop-app rebuild when the developer machine had the app installed, flipping the response to its rebuilding shape; they now stub the rebuild like the rebuild tests do. The selfupdate ownership walk pinned t.TempDir's mode, which inherits the umask and came out group-writable under 002.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End-to-end verification against a live server surfaced four issues; each is its own commit.
What was wrong
aether-standard:v0.1.2-alpha.12, which predates sudo in the standard image) and nothing could ever change that pin. The sudo fix shipped in the image long ago; no existing workspace could receive it.--sync-origin(Finished-run terminal replay, terminal clipboard, and --sync-origin #71) is daemon-only; the GUI had no affordance, so runs forked from a stale server base branch.onboardedflag lives in localStorage, butaether guibinds an ephemeral port, so the origin (and the flag) changed every launch.CommitAllran hooks, fsmonitor, and clean filters from the agent-writable checkout as the server user.What happens now
workspace.imagecontrol method;aether workspace settings --image; Manage workspaces shows each workspace's image with a one-click update when the server's standard image is newer.repo.synclocal-gateway verb + Settings "Sync from origin" button: fetches origin, fast-forwards the server's base branch, never forced, local branch and worktree untouched.linkedgateway as onboarded before the redirect decision..git/info/attributes.Verification
make fmt-check vet lint testgreen;bun run typecheck+ full vitest (572 tests) green. Verified live: deployed to a real server, updated a stale workspace image through the dashboard, synced the base branch (git's own output shown), launched an omp run that provedsudo whoami-> root on the new image, committed, and pulled the branch - forked from the current origin/main tip.