URGENT unblock: split analysis_rerank tests to clear the 1000-line commit gate (fleet cannot commit)

[runyourempire]

Why this is urgent

src-tauri/src/analysis_rerank.rs landed at 1032 lines in #423, over the 1000-line hard error threshold in scripts/check-file-sizes.cjs. That script exits 1, and .husky/pre-commit:38-41 treats a non-zero exit as blocking:

node scripts/check-file-sizes.cjs || {
    echo "File size check failed. Split large files or add justified exceptions."
    exit 1
}

Every developer on this repo currently cannot commit anything locally. This PR restores that.

How it got in

#423 was Rust-only, so CI's Frontend job — the only place the file-size check runs — was skipped by the path filter and the gate never fired. The CI path-filter fix is a separate change owned by another agent; this PR deliberately does not touch .github/workflows/.

What this does

Option A (split), not an exception-list entry. The file had a self-contained 169-line inline #[cfg(test)] mod rerank_breaker_tests block at the bottom, which is the cleanest possible seam — it touches zero production logic.

Moved it into src-tauri/src/analysis_rerank_tests.rs, declared with:

#[cfg(test)]
#[path = "analysis_rerank_tests.rs"]
mod rerank_breaker_tests;

This is the established pattern in this crate — 45 other modules already use #[cfg(test)] #[path = "*_tests.rs"] mod ...; with the test file holding the module body directly (e.g. adversarial.rs:495-497). Test files get 2x the size limit, so the extracted file sits well inside it.

File	Before	After	Status
analysis_rerank.rs	1032	866	warn only (non-blocking)
analysis_rerank_tests.rs	—	166	test file, exempt from warnings

The module name is unchanged, so test paths stay analysis_rerank::rerank_breaker_tests::* — no test-name churn.

Verification

Gate, before and after:

# before
1 file(s) exceed error threshold. Split large files or add justified exceptions.
EXIT=1

# after
43 file(s) approaching size limits (warnings only).
EXIT=0

Check	Result
node scripts/check-file-sizes.cjs	exit 0 (was exit 1)
cargo fmt --check	clean
cargo clippy -- -D warnings (default)	clean
cargo clippy --features experimental -- -D warnings	clean
cargo test --lib	4290 passed, 0 failed, 10 ignored

The test count is identical to the pre-change baseline measured on the same tree. Beyond the count, a full test-name set diff between the two runs shows 4300 unique names on both sides, 0 added, 0 removed — proving nothing was orphaned by the module move (a missed #[path] declaration would silently drop tests, which a passing run alone would not catch).

The production diff is a single hunk starting at line 862; everything above it is byte-for-byte untouched. The extracted body was verified as a byte-exact dedent of the original, with the only difference being rustfmt's re-wrap of the use super::{...} block at the reduced indent level.

Notes for the reviewer

• Rebased onto latest main (4e8e197b, fix(scheduler): contain panics so a bad cycle skips instead of wedging background refresh #428). No overlap — fix(scheduler): contain panics so a bad cycle skips instead of wedging background refresh #428 does not touch analysis_rerank.rs.
• Local pre-commit and pre-push hooks both ran in full and passed. No --no-verify was used anywhere. (Hooks were invoked via git -c core.hooksPath=.husky ... so the worktree ran its own tracked hooks rather than the shared tree's core.hooksPath absolute path — that is the correct branch's gate, not a bypass.)
• cargo audit reports a pre-existing RUSTSEC-2026-0221 (event-listener unsound) on main; unrelated to this change and warn-only in the hook.
• The exception list in scripts/check-file-sizes.cjs was not touched. Worth a separate cleanup pass: it reportedly carries 5 stale entries for deleted files and 3 with false justifications.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AUeKTKwNmdow8yUk3q8RB2

[runyourempire]

Live confirmation of the CI gap on this very PR: Frontend reports skipping (it only triggers on src/**, scripts/**, package.json, etc.), and node scripts/check-file-sizes.cjs --ci lives inside that job at validate.yml:114. So CI will not run the file-size check on this PR either — the same path-filter gap that let #423 through. The exit-0 result is proven locally only (output in the PR body). Worth keeping in mind when merging: the separate CI path-filter fix is what makes this self-verifying in future.