Skip to content

fix: Re-add nme to pyinstaller bundle - #1444

Merged
Czaki merged 2 commits into
developfrom
fix/pyinstaller_nme
Aug 4, 2026
Merged

fix: Re-add nme to pyinstaller bundle#1444
Czaki merged 2 commits into
developfrom
fix/pyinstaller_nme

Conversation

@Czaki

@Czaki Czaki commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Some plugins still uses nme in place of local-migrator

fix PARTSEG-10B

Summary by CodeRabbit

  • Chores
    • Updated optional dependencies to enhance compatibility with older plugins.

Some plugins still uses nme in place of local-migrator

fix PARTSEG-10B
@Czaki Czaki added this to the 0.17.1 milestone Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5a656844-e423-4bee-bf7f-15590846990b

📥 Commits

Reviewing files that changed from the base of the PR and between 9692305 and c6550f6.

📒 Files selected for processing (1)
  • pyproject.toml

📝 Walkthrough

Walkthrough

The optional pyinstaller_base dependency list now includes nme for compatibility with older plugins.

Changes

PyInstaller compatibility

Layer / File(s) Summary
Update PyInstaller dependency declaration
pyproject.toml
The pyinstaller_base optional dependency list includes nme.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes re-adding nme to the PyInstaller bundle.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pyinstaller_nme

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.58%. Comparing base (9692305) to head (c6550f6).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1444   +/-   ##
========================================
  Coverage    92.58%   92.58%           
========================================
  Files          211      211           
  Lines        33230    33230           
========================================
  Hits         30765    30765           
  Misses        2465     2465           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

@Czaki Czaki added the skip check PR title skip spellcheking PR title label Aug 4, 2026
@Czaki
Czaki merged commit 6cd1e6d into develop Aug 4, 2026
67 of 69 checks passed
@Czaki
Czaki deleted the fix/pyinstaller_nme branch August 4, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip check PR title skip spellcheking PR title

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant