Skip to content

fix: align English tag detail and article pages with Turkish versions #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omerfdmrl merged 1 commit into from
Jun 29, 2026
Merged

fix: align English tag detail and article pages with Turkish versions #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/pages/en/articles/[slug].astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import ReadingProgress from '../../../components/ReadingProgress.astro'
import TableOfContents from '../../../components/TableOfContents.astro'
import ArticleNav from '../../../components/ArticleNav.astro'
import ArticleViews from '../../../components/ArticleViews.astro'
import Discussion from '../../../components/discussion/Discussion.tsx'
import { getCollection, render } from 'astro:content'
import { SITE } from '../../../config.mjs'
import { t } from '../../../i18n/index.ts'
Expand Down Expand Up @@ -155,6 +156,8 @@ const onThisPageLabel = t(labels, 'article.onThisPage')
<ArticleNav slug={article.data.slug} category={article.data.category} lang="en" labels={labels} />

<ShareButtons title={article.data.title} url={articleUrl} labels={labels} />

<Discussion client:visible slug={article.data.slug} labels={labels} />
</div>

<TableOfContents headings={tocHeadings} label={onThisPageLabel} title={article.data.title} />
Expand Down
7 changes: 2 additions & 5 deletions src/pages/en/tags/[slug].astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,8 @@ const tagArticles = allArticles.filter(
#{tag.slug}
</h1>
<p class="text-muted-foreground dark:text-muted-dark-foreground mb-8">{tag.description}</p>
{tagArticles.length}
{t(labels, 'tags.articlesTagged')}
<span class="font-mono text-foreground dark:text-foreground-dark">#{tag.slug}</span>.
</div>

<div class="bg-background dark:bg-background-dark rounded-lg shadow-flat-sm overflow-hidden">
<div class="bg-background dark:bg-background-dark rounded-lg shadow-flat-sm overflow-hidden">
{
tagArticles.length === 0 ? (
<div class="px-5 py-8 text-center text-sm text-muted-foreground dark:text-muted-dark-foreground">
Expand Down Expand Up @@ -76,4 +72,5 @@ const tagArticles = allArticles.filter(
)
}
</div>
</div>
</DocsLayout>
Loading