Fixed Ordering of Parameter for event: "Test the elapsed time of a scene timer"

[gautamv95]

Fixes #843

Tasks:

• Update the parameters of the action declared in the extension
• Update the game engine functions
• Add a UpdateInstructionsFromGD4098 that exchange the parameters
• Bump the version of GD Core to 4.0.99
• Compile libGD.js and check that when you open a file it's properly updated

@4ian I cannot find game engine functions related to Time extensions, can you guide me?

[4ian]

@4ian I cannot find game engine functions related to Time extensions, can you guide me?

The link between a GDevelop action/condition and the implementation in the engine is made using SetFunctionName (in C++ files)/setFunctionName (in JS).
In the case of builtin extensions, they are implemented into the platform (GDJS) folder, in the folder "Extensions/Builtin": https://github.com/4ian/GDevelop/blob/master/GDJS/GDJS/Extensions/Builtin/TimeExtension.cpp

This should give you the name of the function you're searching for :)

[gautamv95]

@4ian can you guide me on how do I increase the GDCore version?
I figured it is stored in VersionPriv.h, should I make commits to that file?

EDIT - resolved

[gautamv95]

@4ian, please review

[4ian]

Sorry for the delay! I think this is working fine 👍
The only downside is that this is a breaking change, so I want to wait a bit before merging this - because games opened with the version with this won't be compatible with older version. This can be bad if we release a version that is buggy and ask people to go back to the previous version if we can't release another one quickly.

[gautamv95]

@4ian can you point to the code which is responsible for auto-filling the parameters, when clicked on an instruction?

[Bouh]

Sorry for the late reply @gautamv95
Here where are filled the parameters in the instruction editor.

https://github.com/4ian/GDevelop/blob/master/newIDE/app/src/EventsSheet/InstructionEditor/InstructionParametersEditor.js#L287-L342

[arthuro555]

I propose we make another PR to add compatibility code to core for when this will be added, to have 2-3 version prior supporting the new project file and having a fixed date from which on we can merge this.