-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[PathFinding] Refactor #2373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
D8H
wants to merge
10
commits into
4ian:master
Choose a base branch
from
D8H:RefactorPathFinding
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[PathFinding] Refactor #2373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6418d54 to
9ba67f5
Compare
a3f381c to
24867c5
Compare
9e28a6f to
bb2dcab
Compare
Make tests more concise Run format on tests Report changes from legacy tests on new tests Add the collisionMethod property in the maze example Clean debug code Run format Move the test function in describe Fix documentation Deduce the isometric angle from the cell dimensions Correct the cell height when choosing isometry And raise an explicit exception Fix Ploygon.deepClone typing
Rebase issue
8a32fc5 to
846afd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this PR is based on the PR for isometry, so it can't be merged, it's just to open the discussion)
This is a custom build of GDevelop 5 beta 110 with this change:
https://www.dropbox.com/s/mp5sry99aflw9yv/gdevelop-iso-path-beta110-2021-05-16.7z?dl=1
I did some refactoring on the path finding behavior.
I split a code that was in a mono-block into this:
how nodes must be linked to one another
coordinates <-> node index mapping
The whole thing is independent from the PathFindingRuntimeBehavior so it will allow to write new extensions based on the path finding.