Reduce changes before warning to 1 and fix unwanted changes#4989
Merged
ClementPasteau merged 4 commits intomasterfrom Feb 23, 2023
Merged
Reduce changes before warning to 1 and fix unwanted changes#4989ClementPasteau merged 4 commits intomasterfrom
ClementPasteau merged 4 commits intomasterfrom
Conversation
AlexandreSi
reviewed
Feb 20, 2023
newIDE/app/src/ObjectEditor/Editors/SpriteEditor/DirectionTools.js
Outdated
Show resolved
Hide resolved
4ian
reviewed
Feb 21, 2023
Owner
4ian
left a comment
4ian
left a comment
There was a problem hiding this comment.
lgtm but maybe a second review would help to make sure there is not an obvious regression in the UI or a forgotten "this." somewhere?
ClementPasteau
force-pushed
the
warn-animation-sprite-add
branch
from
41f68f4 to
07c2075
Compare
AlexandreSi
reviewed
Feb 23, 2023
newIDE/app/src/ObjectEditor/Editors/SpriteEditor/CollisionMasksEditor/index.js
Outdated
Show resolved
Hide resolved
AlexandreSi
reviewed
Feb 23, 2023
newIDE/app/src/ObjectEditor/Editors/SpriteEditor/CollisionMasksEditor/index.js
Outdated
Show resolved
Hide resolved
ClementPasteau
force-pushed
the
warn-animation-sprite-add
branch
from
5632b52 to
8744390
Compare
AlexandreSi
approved these changes
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add warnings when animation is added or sprite is added
Enregistrement.de.l.ecran.2023-02-20.a.18.08.40.mov