Clarify Events Sheet blur guard behavior for internal focus moves#8270
Merged
Clarify Events Sheet blur guard behavior for internal focus moves#8270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_onEventsSheetBlurguard so it's explicit that focus transitions to elements inside the events sheet container should not reset keyboard modifiers after the Shift/Ctrl multi-select fix.Description
newIDE/app/src/EventsSheet/index.jsinside_onEventsSheetBlurdocumenting that ifevent.relatedTargetis a descendant of the container, the handler should do nothing and not callthis._keyboardShortcuts.resetModifiers().Testing
cd newIDE/app && npm run check-format, which completed successfully.Codex Task