Conversation
Co-authored-by: Florian Rival <4ian@users.noreply.github.com>
Co-authored-by: Florian Rival <4ian@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4a485926c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| editedVariableLoopEvent | ||
| ? newName => { | ||
| editedVariableLoopEvent.setIndexVariableName(newName); | ||
| } |
There was a problem hiding this comment.
Make loop index edits honor dialog cancel
The onRenameIndexVariable handler mutates editedVariableLoopEvent immediately while the local-variables dialog is open, but LocalVariablesDialog cancel restoration only serializes/unserializes the variables container. If the user renames/removes the loop counter and presses Cancel, the variable data is reverted but indexVariableName stays modified, leaving the loop event referencing the wrong variable (or no local variable at all) and changing runtime behavior unexpectedly.
Useful? React with 👍 / 👎.
Some examples: