Skip to content

Fix tentatively crash in popped-out window when a theme is missing a color #8518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4ian merged 1 commit into from
Apr 17, 2026
+7 −0
Merged

Fix tentatively crash in popped-out window when a theme is missing a color #8518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions newIDE/app/src/Utils/Window.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,13 @@ export default class Window {
static setWindowBackgroundColor(newColor: string, targetDocument?: Document) {
const doc = targetDocument || document;

if (!newColor) {
// Be defensive against themes missing a color (for instance, a
// newly added variable that an older or custom theme doesn't define):
// skip the update rather than crashing.
return;
}

if (documentBackgroundColors.get(doc) === newColor) {
// Avoid potentially expensive DOM query/modification if no changes needed.
return;
Expand Down
Loading