Try to fix Events sheet wrong resizing of events on scroll#8551
Merged
Conversation
ClementPasteau
force-pushed
the
try-fix-scroll-sheet
branch
3 times, most recently
from
c7a652c to
91edf56
Compare
ClementPasteau
force-pushed
the
try-fix-scroll-sheet
branch
from
91edf56 to
22d7e36
Compare
4ian
reviewed
May 5, 2026
| 'BuiltinCommonInstructions::Else': e => gd.asElseEvent(e), | ||
| }; | ||
|
|
||
| const getInstructionsListFromEvent = ( |
Owner
There was a problem hiding this comment.
A while event has getWhileConditions. What's the impact, is this a problem?
Collaborator
Author
There was a problem hiding this comment.
very good remark. It looks like we're giving the same IDs for conditions and whileConditions, I'll look at fixing this
4ian
reviewed
May 5, 2026
| const { _eventsTree: eventsTree } = this; | ||
| if (!eventsTree) return; | ||
|
|
||
| // Clear selection immediately alongside the history update so that stale |
4ian
reviewed
May 5, 2026
| newEventsHistory.futureActions.length - 1 | ||
| ]; | ||
|
|
||
| // Always compute eventContexts — needed for both selection and scroll. |
4ian
reviewed
May 5, 2026
| // which fires the version-gated useLayoutEffect below, calling recomputeRowHeights | ||
| // before the browser paints. Using requestAnimationFrame instead would defer the | ||
| // recompute to after the first paint, causing a visible frame of wrong-size slots. | ||
| const [, forceHeightRecompute] = (React.useReducer(x => x + 1, 0): [ |
Owner
There was a problem hiding this comment.
Use useForceUpdate which does the same
ClementPasteau
force-pushed
the
try-fix-scroll-sheet
branch
from
9356243 to
79922a9
Compare
4ian
approved these changes
May 5, 2026
4ian
approved these changes
May 5, 2026
| return isCondition ? 'conditions' : 'actions'; | ||
| }; | ||
|
|
||
| const getInstructionsListFromEvent = ( |
Owner
There was a problem hiding this comment.
Could have been a const gd::InstructionsList* GetInstructionList(const gd::String& label), re-implemented by each event.
Carefully though, C++ can't return null. If it returns a nullptr, then isNullPtr must be used to check what you got (it's not "null" in jS)
| const gd: libGDevelop = global.gd; | ||
|
|
||
| // Maps event types that have conditions+actions to their gd cast function. | ||
| const eventCasters: { [string]: ?(event: gdBaseEvent) => any } = { |
Owner
There was a problem hiding this comment.
These are a bit ugly in EventsSheet, see my other comment below
4ian
pushed a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8510
before:
Enregistrement.de.l.ecran.2026-04-29.a.17.50.22.mov
After:
Enregistrement.de.l.ecran.2026-05-05.a.10.16.05.mov