-
-
Notifications
You must be signed in to change notification settings - Fork 90
merge v.0.0.2 into master #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a MetricsList class which directly takes the metric data received from prometheus and makes processing it easier
Add `Metric` and `MetricsList` classes to make metric manipulation easier
Add example notebook for Metric and MetricsList classes
* Update sphinx doc stuff * Update docstring for MetricsList class for better sphinx documentation
* Update sphinx doc stuff * Update docstring for MetricsList class for better sphinx documentation
Update version number for v0.0.2b1 release
init a Metric object from an existing Metric object
The Prometheus API exposes at least two optional GET parameters: "time" for evaluating a query at specific moment, and "timeout" for limiting the query runtime. This commit adds the ability to set those parameters (as well as any other GET parameter) while using custom_query().
Added option to specify GET params in custom_query()
… fixes This commit follows up on https://github.com/AICoE/prometheus-api-client-python/pull/19 by adding an optional `params` argument to every function in prometheus_connect that does GET requests, allowing the user to specify additional URL parameters like "time" or "timeout". I also ran the file through autopep8, cleaned up some of the docstrings, fixed a few default-value traps, and added more-consistent type hints.
Added optional argument for GET params to all query functions + style fixes
Add properties `start_time` and `end_time` (datetime objects)
When converting json to a pandas df, it should raise errors when converting string to numbers instead of just ignoring them. This was updated in pandas v0.25.0
Now a MetricsList can be initialized from a list of lists, which is usually the case when reading from json files stored using PrometheusConnect
Add unit tests for class `Metric` and `MetricsList`
Fix for the new pandas release (v0.25.0)
… numpy.datetime64 to datetime.datetime (4n4nd#23) use timestamp to convert numpy.datetime64
Update MetricsList constructor
Configuration for the zuul bot to run tests on this branch
Remove duplicate stored metrics from repo root
For `oldest_data_datetime` parameter, the only accepted input types are `datetime.datetime`/`datetime.timedelta` or `NoneType`
No strings for datetime input for Metric class constructor
No code changes
This adds configuration for Black code formatter
Update to use pyproject.toml as a config for black and not use any other linter
Enable fixers for stickler-ci so it can automatically format new PRs using black
Format using black
Change url for documentation. Add a codacy badge Add installation instructions
…eusConnect Use datetime objects for metric start_time and end_time. Use timedelta objects for chunk_size. Add tests for class PrometheusConnect Move pretty_print_metric function to utils.py
Remove dateparser as a dependency and use datetime objects in PrometheusConnect
Update example notebook
bump version number to 0.0.2b4 for a new pre-release
This warning gets printed every time any piece of the package is imported, even pieces unrelated to plotting. Since the code already throws an ImportError if `plot()` is used without matplotlib being installed, I don't think the warning is necessary.
Remove matplotlib warning
And fix coala errors
Add a .coafile
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
Closed
|
Build failed.
|
Owner
|
👍 LGTM |
4n4nd
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolving conflicts in favor of v0.0.2