Skip to content

Conversation

@kdemmich
Copy link
Collaborator

@kdemmich kdemmich commented Jan 15, 2026

Related Issue / Discussion:

Fixes Issues #116, 52North/WRT-Issues#1

Changes:

  • Modified all Mutation, Patcher, Population classes
  • Modified unit tests for the genetic algorithm
  • Modified unit tests for RouteParams
  • Deleted crossover.PMX as redundant

Further Details:

Summary:

See Issue #116.

Dependencies:

pytest-plt

PR Checklist:

In the context of this PR, I:

@kdemmich kdemmich marked this pull request as ready for review January 19, 2026 11:58
:param src: Source waypoint as (lat, lon, v) triple
:type src: tuple[float, float, float]
:param dst: Destination waypoint as (lat, lon, v) triple
:type dst: tuple[float, float, float]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the type hints of the method arguments?
Instead of src: tuple, dst: tuple write src: tuple[float, float, float], dst: tuple[float, float, float]

:param src: Source waypoint as (lat, lon, speed) triple
:type src: tuple[float, float, float]
:param dst: Destination waypoint as (lat, lon, speed) triple
:type dst: tuple[float, float, float]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add type hints of the method arguments?
Instead of src, dst write src: tuple[float, float, float], dst: tuple[float, float, float]

@kdemmich kdemmich merged commit 269a954 into main Jan 26, 2026
1 check passed
@kdemmich kdemmich deleted the OptimiseSpeedGA branch January 26, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants