UNKNOW is used as owners name if the owners were not renamed during importing safe

[liliya-soroka]

Title/Description

UNKNOW is used as owners name if the owners were not renamed during importing safe ( the same presents in 3.5.2)

Environment

• Browser: Chrome/FF
• Safe: alice.eth
• Wallet: MM
• App Version: 3.6.0
• Environment:
  • PR # https://pr2246--safereact.review.gnosisdev.com/mainnet/app/#/safes/0xcd2E72aEBe2A203b84f46DEEC948E6465dB51c75/settings

Steps to reproduce

1. Load existed safe
2. Leave the owners names as Owner#1 ...
3. add safe
4. go to the safe settings->Owners

Expected result

Default names : Owner#1 ... should be used if the owners were are not renamed

Obtained result

The owners without names( not saved to addressbook) have UNKNOWN as default name instead of owner #1...

Screenshots

[liliya-soroka]

as result UNKNOWN is used all over the app :

[tschubotz]

Marking this as major since existing address book names would be overwritten.

[dasanra]

This will be improved in address book refactor. For me it's not a major bug, we are just showing UNKNOWN for names that aren't stored in the address book. If we store a name in the address book the UNKNOWN is replaced by the selected name

[tschubotz]

hmm not sure why I wrote "since existing address book names would be overwritten.". 🤔
agree that it's not major then.

[dasanra]

This can be tested in #2280

[francovenica]

Safe and env:
https://pr2293--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/settings

I just checked in the #2280 and it still shows "UNKNOWN" for the users that didn't get a name during safe loading (during safe creation there is no problem because the name input comes empty so you are forced to give the owners a name). So it seems that whatever ticket that takes care of this has not being merged into that epic yet.

I also checked the ticket #2293 (I assume this ticket will be merged into the 2280) and there the names are just non existent in the settings. It should be the "Owner #X"