Deep link - Inconsistent data while the a tx is being executed

[francovenica]

Description

While you are in the deep link view of a tx that is currently being executed a lot of data is inconsistent or not the same as it was with the previous configuration.
This was tested in a safe with a 1 out of X owner policy

• The tx shows "0 out of 1" owners signed
• The list shows that the "tx X needs to be executed first" when that is the tx currently being executed
• After it executes, the message changes to "tx X+1 needs to be executed first"
• The status of the tx should be in "Pending" with a loading icon

Environment

• Browser: Chrome
• Wallet: MetaMask
• Safe: https://pr2974--safereact.review-safe.gnosisdev.com/app/rin:0x6bb36b84abCb0Db1c8E2CAe68677D28DF73D99DF/transactions/queue
• Policy: 1 out of X owners
• Environment:
  Feature: deep-linking a single tx #2974

Steps to reproduce

Create a safe with 1 owner
Create a tx (any type of tx, like adding an owner will suffice)
The system opens the tx in the "Deep link" view

Expected result

The status of the tx should be "Pending" with a loading icon
The signature should be "1 out of 1" owners
The message "Tx x needs to be executed first" should not be there

Obtained result

Everything opposed of what it was written in "Expected results"

Gif

Is 1min and 30 secs long.

Note:

In the gif is shown that the "Confirm" and "Reject" buttons are present and that's an issue as well, but they are already addressed in the ticket #3058

[iamacook]

These issues arise because the immediately created transaction is awaiting execution on the blockchain. I brought this up with backend and was advised that it will exectue no matter what. It 'fixes' itself after it polls again for the list of transactions and/or you refresh the deeplink.

Perhaps we should manually set deeplinked, on-chain rejections automatically to pending? The other issues regarding confirmation requirements are hopefully just a miscalculation and we can reference the numbers of Safe owners.

[francovenica]

The text above the tx maybe can just be hide from this view.
The 0 out of 1 is something we gotta fix
The Pending status helps the user to understand that the process is ongoing, if nothing happens it seems that the tx didn't go through or is frozen or something like that.

We can discuss what it can be done from our side. Still I don't consider these issues as a big problem, they could be ignored for a bit if we deploy a v1 at some point

[iamacook]

Just going to add my thoughts so that we can reference them again later on.

I assume the text at the top is a bug. It's the normal label that is in place of the tabs. There are a few keys which could be used as an alternative. It may be related to the transaction 'location.

0 out of 1 is related to singular owners and immediate submission of transactions. I think we can use the number of owners as a flag, but we'll need to look into it.

Regarding the pending status, it's a difficult one because it is a 'local' status. We'll find a solution though 🦾

[DiogoSoaress]

Might be tightly related with #3070 as we are issuing an unnecessary ADD_QUEUED_TRANSACTIONS with only 1 signer

[francovenica]

The inconsistent data is not showing anymore, that's why we merged this ticket. Any new bugs are going to fixed in new tickets