This repository was archived by the owner on Nov 10, 2023. It is now read-only.
[Address Book V2] Import address book#2290
Merged
Merged
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
[warning] @typescript-eslint/explicit-module-boundary-types
Report generated by eslint-plus-action |
katspaugh
suggested changes
May 17, 2021
katspaugh
suggested changes
May 17, 2021
7ba2381 to
ca6f1b5
Compare
dcfb25a to
0099089
Compare
katspaugh
reviewed
May 17, 2021
…/gnosis/safe-react into feature/2236-import-address-book
…/gnosis/safe-react into feature/2236-import-address-book
katspaugh
reviewed
May 21, 2021
| textOverflow: 'ellipsis', | ||
| whiteSpace: 'nowrap', | ||
| lineClamp: '2', | ||
| wordBreak: 'break-all', */ |
Contributor
There was a problem hiding this comment.
Could you replace this comment with:
max-height: 50px;
overflow: hidden;
This should fix long file names.
katspaugh
approved these changes
May 21, 2021
katspaugh
left a comment
Contributor
There was a problem hiding this comment.
Looks and works amazing!
Great work guys!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Closes #2236
Why:
We are adding the import of CSV files to let the user load entries to the address book
How:
Added a modal that let's you load a single file and gives you feedback on how many entries have been loaded
How to test it:
Checklist:
Right now the entries are saved using
addAddressBookEntry(). This will not overwrite the name of an entry that's already in the store. This will be changed on the store refactor.