Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

[Address Book V2] Import address book#2290

Merged
katspaugh merged 26 commits into
address-book-v2from
feature/2236-import-address-book
May 21, 2021
Merged

[Address Book V2] Import address book#2290
katspaugh merged 26 commits into
address-book-v2from
feature/2236-import-address-book

Conversation

@juampibermani

@juampibermani juampibermani commented May 13, 2021

Copy link
Copy Markdown
Contributor

What:

Closes #2236

Why:

We are adding the import of CSV files to let the user load entries to the address book

How:

Added a modal that let's you load a single file and gives you feedback on how many entries have been loaded

How to test it:

  • Enter the address book page
  • Click on the top right Import button
  • Load a CSV file (also supports xls and xlsx files) that has two columns (address, name)
  • Click on import
  • Entries should be added and a notification should appear

Checklist:

  • Tests added/updated "N/A"
  • Ready to be merged "N/A"

Right now the entries are saved using addAddressBookEntry(). This will not overwrite the name of an entry that's already in the store. This will be changed on the store refactor.

@juampibermani juampibermani self-assigned this May 13, 2021
@github-actions

Copy link
Copy Markdown

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions

github-actions Bot commented May 13, 2021

Copy link
Copy Markdown

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 2 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 2 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

@alongoni alongoni changed the title Feature/2236 import address book [Address Book V2] Import address book May 14, 2021
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx
@katspaugh katspaugh self-requested a review May 17, 2021 08:04
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
@juampibermani juampibermani force-pushed the feature/2236-import-address-book branch from 7ba2381 to ca6f1b5 Compare May 17, 2021 15:47
@juampibermani juampibermani force-pushed the feature/2236-import-address-book branch from dcfb25a to 0099089 Compare May 17, 2021 16:14
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
textOverflow: 'ellipsis',
whiteSpace: 'nowrap',
lineClamp: '2',
wordBreak: 'break-all', */

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace this comment with:

    max-height: 50px;
    overflow: hidden;

This should fix long file names.

@katspaugh katspaugh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works amazing!
Great work guys!

@katspaugh katspaugh merged commit 28afa59 into address-book-v2 May 21, 2021
@katspaugh katspaugh deleted the feature/2236-import-address-book branch May 21, 2021 12:41
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants