This repository was archived by the owner on Nov 10, 2023. It is now read-only.
Export - Add loading state when click on download button#2325
Merged
Conversation
matextrem
added
the
Enhancement ✨
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
suggested changes
May 25, 2021
Contributor
|
Noticed a bug: after you've downloaded the CSV once, it won't let you download it again unless you refresh the page. |
…eature/export-loading-state
Contributor
Author
|
@katspaugh can you test again ? It's working for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it solves
There is no feedback for the user when click on download button in order to export the address book.This PR closes #2305
How this PR fixes it
This PR adds a loading spinner when you click on the download button in order to show a feedback to the user that the file is being downloaded.
How to test it