This repository was archived by the owner on Nov 10, 2023. It is now read-only.
[Address Book v2] 1603 Use addressbook over known addresses#2352
Merged
dasanra merged 5 commits intoJun 1, 2021
Merged
Conversation
added 5 commits
May 27, 2021 18:33
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
May 31, 2021
| <AddressInfo address={address} name={name} avatarUrl={avatarUrl} /> | ||
| <EllipsisTransactionDetails | ||
| address={address} | ||
| knownAddress={knownAddress} |
Collaborator
Author
There was a problem hiding this comment.
Instead of passing it as a prop I fetched the info where it was needed
katspaugh
approved these changes
May 31, 2021
fernandomg
approved these changes
May 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it solves
Closes #1603 to ensure the use of values stored in the address book over the ones from backend for known addresses
How this PR fixes it
In this PR we check those places where we use Known Addresses to have higher priority showing Address book information over information from backend
How to test it
Go through the app checking that we use correct names when stored in address book. Always assume highest priority for the name stored in address book. When name is not stored in the address book, if the address is a
knownAddresswe should display the values from backendAny extra information
There were just few changes and long revision. Detected some places where even the name weren't used (SendCollectibles review and Contract Interaction review). In general it's also fixing some hardcoded values that I found
In Rinkeby Compound app uses a "known smart contract" Can be used for checking in transactions list.