Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Feature/2317 update import export global ab#2370

Merged
juampibermani merged 9 commits into
address-book-v2from
feature/2317-update-import-export-global-ab
Jun 2, 2021
Merged

Feature/2317 update import export global ab#2370
juampibermani merged 9 commits into
address-book-v2from
feature/2317-update-import-export-global-ab

Conversation

@juampibermani

Copy link
Copy Markdown
Contributor

What it solves

Closes #2317

How this PR fixes it

After the import is done, the entries are saved in the store

How to test it

Export the address book using the export modal
Delete some entries from the address book
Use the import modal to add entries to the address book
(Edit the csv with invalid data to check the error messages)

@github-actions

github-actions Bot commented Jun 1, 2021

Copy link
Copy Markdown

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions

github-actions Bot commented Jun 1, 2021

Copy link
Copy Markdown

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 4 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 4 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

Comment thread src/logic/addressBook/store/reducer/index.ts Outdated
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx
Comment thread src/routes/safe/components/AddressBook/ImportEntryModal/index.tsx Outdated
@github-actions

github-actions Bot commented Jun 1, 2021

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jun 1, 2021

Copy link
Copy Markdown

@juampibermani juampibermani requested a review from katspaugh June 1, 2021 15:39
@@ -92,16 +91,19 @@ const ImportEntryModal = ({ importEntryModalHandler, isOpen, onClose }) => {
const validateCsvData = (data) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we extract the validation functions as utils, type them and add tests?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create an issue to address this

@katspaugh katspaugh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
There's just one eslint issue.

@katspaugh katspaugh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

Comment thread src/routes/safe/components/AddressBook/ImportEntriesModal/index.tsx Outdated
@juampibermani juampibermani merged commit c5207f7 into address-book-v2 Jun 2, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 2, 2021
@katspaugh katspaugh deleted the feature/2317-update-import-export-global-ab branch June 3, 2021 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants