This repository was archived by the owner on Nov 10, 2023. It is now read-only.
Feature/2317 update import export global ab#2370
Merged
juampibermani merged 9 commits intoJun 2, 2021
Merged
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
[warning] @typescript-eslint/explicit-module-boundary-types
Report generated by eslint-plus-action |
katspaugh
suggested changes
Jun 1, 2021
fernandomg
approved these changes
Jun 1, 2021
| @@ -92,16 +91,19 @@ const ImportEntryModal = ({ importEntryModalHandler, isOpen, onClose }) => { | |||
| const validateCsvData = (data) => { | |||
Contributor
There was a problem hiding this comment.
can we extract the validation functions as utils, type them and add tests?
Contributor
Author
There was a problem hiding this comment.
I'll create an issue to address this
katspaugh
suggested changes
Jun 2, 2021
katspaugh
left a comment
Contributor
There was a problem hiding this comment.
Looks good!
There's just one eslint issue.
fernandomg
reviewed
Jun 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it solves
Closes #2317
How this PR fixes it
After the import is done, the entries are saved in the store
How to test it
Export the address book using the export modal
Delete some entries from the address book
Use the import modal to add entries to the address book
(Edit the csv with invalid data to check the error messages)