This repository was archived by the owner on Nov 10, 2023. It is now read-only.
[Address Book v2] - Avoid deleting addressBook entry when deleting a safe#2374
Merged
katspaugh merged 2 commits intoJun 2, 2021
Merged
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
fernandomg
force-pushed
the
fix/2353-preserve-ab_name-deleted-safe
branch
from
dab2fa7 to
37297ca
Compare
ESLint Summary View Full Report
Report generated by eslint-plus-action |
dasanra
approved these changes
Jun 2, 2021
Contributor
|
The safe addresses are not longer being removed when the safe is being removed from its own settings. Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it solves
fixes #2353
How this PR fixes it
Stop from dispatching
addressBook/removeaction when deleting a SafeHow to test it
Follow steps in issue #2353