DIVE-3512: do not let a missing readelf abort the installer - #4
Merged
Conversation
readelf ships with binutils and is not guaranteed on a minimal server image, which is exactly the kind of box this script targets. It was called in three places inside command substitutions under `set -euo pipefail`, so on a box without it the script would abort — including inside the die() that refuses to overwrite an existing binary, turning a careful refusal into a crash. It is only ever used to PRINT identity, never to decide whether to install, so it now degrades to a message naming the missing package rather than failing. The checksum verification that actually gates the install is unaffected: it uses sha256sum, which is still a hard requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readelfships with binutils and is not guaranteed on a minimal server image, which is exactly the kind of boxinstall-buzz-cli.shtargets. It was called in three places inside command substitutions underset -euo pipefail, so on a box without it the script aborts — including inside thedie()that refuses to overwrite an existing binary, turning a careful refusal into a crash.It is only ever used to PRINT identity, never to decide whether to install, so it now degrades to a message naming the missing package. The checksum verification that actually gates the install is untouched: that uses
sha256sum, still a hard requirement.Found by reading the script against its target environment rather than by running it — this host must carry nothing buzz-shaped, so the installer has not been executed end to end anywhere yet. That gap is named on DIVE-3512 and belongs to the sure-redwood row.