fix: add distributed lock to dedicated server assignment#139
Merged
Conversation
Lock failures on assignDedicatedServer now log and fall through to alternative assignment strategies instead of propagating unhandled. Lock TTL reduced from default 60s to 10s to match on-demand pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assignDedicatedServer()method's query-assign-reserve flow in acache.lock()call to prevent race conditions where two matches could claim the same dedicated serverassign-dedicated-server:{region}) since servers are region-specific, matching the existing pattern used for on-demand serversCloses 5stackgg/5stack-panel#373
Test plan