Skip to content

fix: add distributed lock to dedicated server assignment #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukepolo merged 2 commits into from
Apr 9, 2026
Merged

fix: add distributed lock to dedicated server assignment #139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
721e223
fix: add distributed lock to dedicated server assignment to prevent r…
Flegma Apr 8, 2026
889042f
fix: add error handling for lock acquisition and set 10s TTL
Flegma Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
154 changes: 87 additions & 67 deletions src/matches/match-assistant/match-assistant.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,14 +232,21 @@ export class MatchAssistantService {
});

if (match.options.prefer_dedicated_server) {
const assignedDedicated = await this.assignDedicatedServer(
match.id,
match.region,
);

if (assignedDedicated) {
await this.startMatch(matchId);
return;
try {
const assignedDedicated = await this.assignDedicatedServer(
match.id,
match.region,
);

if (assignedDedicated) {
await this.startMatch(matchId);
return;
}
} catch (error) {
this.logger.error(
`[${matchId}] unable to assign dedicated server`,
error,
);
}
}

Expand Down Expand Up @@ -272,9 +279,16 @@ export class MatchAssistantService {
return;
}

if (await this.assignDedicatedServer(match.id, match.region)) {
await this.startMatch(matchId);
return;
try {
if (await this.assignDedicatedServer(match.id, match.region)) {
await this.startMatch(matchId);
return;
}
} catch (error) {
this.logger.error(
`[${matchId}] unable to assign dedicated server`,
error,
);
}

this.logger.log(
Expand Down Expand Up @@ -322,72 +336,78 @@ export class MatchAssistantService {
matchId: string,
region: string,
): Promise<boolean> {
const { servers } = await this.hasura.query({
servers: {
__args: {
limit: 1,
where: {
connected: {
_eq: true,
},
enabled: {
_eq: true,
},
is_dedicated: {
_eq: true,
},
type: {
_eq: "Ranked",
},
reserved_by_match_id: {
_is_null: true,
},
region: {
_eq: region,
return this.cache.lock(
`assign-dedicated-server:${region}`,
async () => {
const { servers } = await this.hasura.query({
servers: {
__args: {
limit: 1,
where: {
connected: {
_eq: true,
},
enabled: {
_eq: true,
},
is_dedicated: {
_eq: true,
},
type: {
_eq: "Ranked",
},
reserved_by_match_id: {
_is_null: true,
},
region: {
_eq: region,
},
},
},
id: true,
},
},
id: true,
},
});
});

const server = servers.at(0);
const server = servers.at(0);

if (!server) {
return false;
}
if (!server) {
return false;
}

this.logger.log(`[${matchId}] assigning on dedicated server`);
this.logger.log(`[${matchId}] assigning on dedicated server`);

await this.hasura.mutation({
update_matches_by_pk: {
__args: {
pk_columns: {
id: matchId,
},
_set: {
server_id: server.id,
await this.hasura.mutation({
update_matches_by_pk: {
__args: {
pk_columns: {
id: matchId,
},
_set: {
server_id: server.id,
},
},
__typename: true,
},
},
__typename: true,
},
});
});

await this.hasura.mutation({
update_servers_by_pk: {
__args: {
pk_columns: {
id: server.id,
},
_set: {
reserved_by_match_id: matchId,
await this.hasura.mutation({
update_servers_by_pk: {
__args: {
pk_columns: {
id: server.id,
},
_set: {
reserved_by_match_id: matchId,
},
},
__typename: true,
},
},
__typename: true,
},
});
});

return true;
return true;
},
10,
);
}

private async assignOnDemandServer(matchId: string): Promise<boolean> {
Expand Down
Loading