fix: only assign CellRangeSelector when Hybrid has dragToSelect set
#1174
+24
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially reverts PR #1164 and commit 43e31fa
I previously added a
row-clickas selection type in the new Hybrid Selection, because I taught that I needed it since it behave differently when comparing Row Selection and the new Hybrid Selection (e.g. Master/Detail grids example). But in reality, the real problem was simply a missing condition in which we should only instantiateSlickCellRangeDecoratoras selector when undefined and whendragToSelectis enabled and that was the missing piece in the new Hybrid Model. After adding the missing condition, the Hybrid Selection Model is now behaving the same as the Row Selection Model and/or Cell Selection Model.Note: I discovered this issue while working on dropping
SlickCellSelectionModel&SlickRowSelectionModelin Slickgrid-Universal to replace them entirely with a singleSlickHybridSelectionModelthat handles both type of selections