Skip to content

fix(design-mcp): declare pageMap object schema so hosts can send it #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7shep merged 1 commit into from
Aug 1, 2026
Merged

fix(design-mcp): declare pageMap object schema so hosts can send it #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions packages/design-mcp/src/art-director-mcp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,20 @@ const requestIdSchema = z
.min(1)
.optional()
.describe('Stable retry id. Reusing it with a different payload is rejected.');
/**
* `z.unknown()` compiles to an empty JSON Schema, and MCP hosts serialize
* untyped parameters as strings. The engine's `validatePageMap` then rejects
* the value because it is not a record. Declaring the object shape keeps the
* payload structured over the wire; the engine still owns full validation.
*/
const pageMapSchema = z
.object({
kind: z.enum(['single-page', 'multi-page']),
pages: z.array(z.record(z.string(), z.unknown())).min(1)
})
.passthrough()
.optional()
.describe('PageMap object. Validated in full by the design engine.');

function toolResult(value: unknown) {
return { content: [{ type: 'text' as const, text: JSON.stringify(value, null, 2) }] };
Expand Down Expand Up @@ -162,7 +176,7 @@ export function registerArtDirectorTools(
sessionId: z.string().min(1).optional(),
requestId: requestIdSchema,
interpretations: z.array(z.unknown()).optional(),
pageMap: z.unknown().optional()
pageMap: pageMapSchema
},
async (input) =>
safeToolResult(() =>
Expand All @@ -189,7 +203,7 @@ export function registerArtDirectorTools(
requestId: requestIdSchema,
answers: z.array(z.unknown()).optional(),
interpretations: z.array(z.unknown()).optional(),
pageMap: z.unknown().optional()
pageMap: pageMapSchema
},
async ({ session, ...input }) =>
safeToolResult(() =>
Expand Down Expand Up @@ -219,7 +233,7 @@ export function registerArtDirectorTools(
requestId: requestIdSchema,
decisions: z.array(z.unknown()).optional(),
interpretations: z.array(z.unknown()).optional(),
pageMap: z.unknown().optional()
pageMap: pageMapSchema
},
async ({ session, ...input }) =>
safeToolResult(() =>
Expand Down
Loading