Conversation
Add: -Main page; -First choice page; -Second choice page; -lose page; -Servlets(Redirect,MainController and other).
Add: -Main page; -First choice page; -Second choice page; -lose page; -Servlets(Redirect,MainController and other).
Volodymyr95
reviewed
Nov 27, 2023
|
|
||
| <dependencies> | ||
|
|
||
| <!-- <dependency>--> |
There was a problem hiding this comment.
don't push commented dependencies and code
| import javax.servlet.http.HttpServletResponse; | ||
| import java.io.IOException; | ||
|
|
||
| @WebServlet("/FirstPage") |
| @WebServlet("/FirstPage") | ||
| public class FirstPage extends HttpServlet { | ||
| @Override | ||
| protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException { |
| import java.io.IOException; | ||
|
|
||
|
|
||
| @WebServlet(name = "MainController" , value = "/Main") |
There was a problem hiding this comment.
name paramter is optional, use url name from lower case first letter
| } | ||
|
|
||
| @Override | ||
| protected void doPost(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException { |
There was a problem hiding this comment.
why empty? is not needed just delete it
| @@ -0,0 +1,18 @@ | |||
| package web; | |||
|
|
|||
| public class AcceptService { | |||
| public String call(String answer){ | ||
|
|
||
| String redirectURL; | ||
| if("FirstPage".equals(answer)){ |
There was a problem hiding this comment.
create and use constants for content
|
missed unit tests and logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.