Conversation
Add: -Main page; -First choice page; -Second choice page; -lose page; -Servlets(Redirect,MainController and other).
Add: -Main page; -First choice page; -Second choice page; -lose page; -Servlets(Redirect,MainController and other).
Change: -Main logic; -All pages; -Add a couple of tests and logs(don`t work); - Add a little story and other some changes.
Volodymyr95
reviewed
Dec 13, 2023
| import javax.servlet.http.HttpServletResponse; | ||
| import java.io.IOException; | ||
|
|
||
| @WebServlet("/first_question") |
There was a problem hiding this comment.
firstQuestion , use cammelCase syntax
|
|
||
| @WebServlet("/first_question") | ||
| public class FirstQuestionPage extends HttpServlet { | ||
| private final static Logger LOGGER = LoggerFactory.getLogger(FirstQuestionPage.class); |
There was a problem hiding this comment.
make all logger words in upper case
| import java.io.IOException; | ||
|
|
||
| @WebServlet("/first_question") | ||
| public class FirstQuestionPage extends HttpServlet { |
|
|
||
|
|
||
| @WebServlet("/main") | ||
| public class MainPage extends HttpServlet { |
| private final static Logger LOGGER = LoggerFactory.getLogger(MainPage.class); | ||
| @Override | ||
| protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException { | ||
| LOGGER.warn("User on Main page."); |
| private final static Logger LOGGER = LoggerFactory.getLogger(MainPage.class); | ||
| @Override | ||
| protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException { | ||
| LOGGER.warn("User on Main page."); |
|
|
||
|
|
||
|
|
||
| class MainPageTest { |
There was a problem hiding this comment.
unit tests add only for buisness logic(service layer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second version of logic.
Change:
-Main logic;
-All pages;
-Add a couple of tests and logs(don`t work);