fix: prevent index out of range panic on 32-bit platforms#415
Merged
9seconds merged 1 commit into9seconds:masterfrom Mar 29, 2026
Merged
Conversation
On 32-bit architectures (e.g. ARM7), int is 32 bits wide. Casting a uint32 hash value to int can overflow, producing a negative number. Go's modulo operator preserves the sign, so the channel index can become -1, causing a panic. Perform the modulo in uint32 space before indexing to ensure the result is always non-negative. Fixes 9seconds#413
Closed
Owner
|
Кажется, новый релиз будет состоять в основном из вашей работы :) |
Contributor
Author
Опенсорс засасывает, особенно в выходные :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 32-bit architectures (e.g. ARM7),
intis 32 bits wide. Casting auint32hash value tointcan overflow, producing a negative number. Go's modulo operator preserves the sign, so the channel index can become-1, causing a panic:This happens roughly 50% of the time — whenever the xxhash result exceeds
math.MaxInt32.The fix performs the modulo in
uint32space before indexing the slice, ensuring the result is always non-negative.Fixes #413