Conversation
dolonet
added a commit
to dolonet/mtg-multi
that referenced
this pull request
Apr 1, 2026
Upstream replaced our reassembleTLSHandshake with a cleaner fragmentedHandshakeReader + parseClientHello in utils.go. Adapted ReadClientHelloMulti to use the new API.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not bring anything new comparing to #431 and great @appolimp work. Since this is a very sensitive and crucial part, I just refactored that and re-implemented some bits. This area was a bit new to me, so it makes a lot of sense to me, as a maintainer, to understand each and every bit of this code. You can think about refactoring as a learning procedure that fills my neurons with a new information.
Previous code was great and concise, no doubts about it. Learning and understanding are purposes of this PR.