Suppress device disconnect notifications during bodyweight-only workouts

[9thLevelSoftware]

Summary

Feature request to disable or suppress device connection monitoring when performing a bodyweight-only workout (no Vitruvian trainer exercises).

Problem

When the user performs a bodyweight workout (e.g., pull-ups) that does not use the Vitruvian trainer, the app still monitors the device connection. Since the Vitruvian trainer auto-powers-off after 15 minutes of inactivity, the app shows a disconnect notification mid-workout, interrupting the user's flow.

Use Case

• User performs pull-ups in their basement, away from the Vitruvian trainer
• Workout structure: 20 rounds, EMOM (Every Minute on the Minute) style, lasting ~20 minutes
• After 15 minutes of trainer inactivity, the Vitruvian powers off
• The Phoenix app detects the disconnect and shows an interruption notification
• Resetting the device sometimes clears the notification, but this disrupts the workout

Proposed Behavior

When all exercises in a workout are bodyweight-only (no machine resistance), the app should not monitor or alert on device connection status — or at minimum, suppress the disconnect notification until the workout is complete.

Current Behavior

The app interrupts the workout with a device disconnect notification even when the user is not using the Vitruvian trainer for any exercise.

Impact

• User experience disruption during timed bodyweight workouts
• Particularly affects longer EMOM-style or circuit workouts where the trainer's 15-min auto-off threshold is exceeded
• Workaround (resetting the device) is unreliable and further disrupts the workout

Reporter

Discord user: yeahpotato (342791041646198795)

---

Original Discord Request

<@1502654170031849644> Feature request Is it possible for the app to not check for device connection when doing a bodyweight workout?

I have a set where I do pull ups for 20 minutes (in my basement, away from the vitruvian). The exercise has 20 rounds (emom style). Since the vitruvian trainer turns off after 15 mins of inactivity, the Phoenix app "interrupts" with a disconnect notification. Resetting the device sometimes clears the notification

[9thLevelSoftware]

Feasibility Assessment: ACCEPT

Recommendation: Accept for implementation.

Summary: The connection-loss alert logic in BleConnectionManager does not distinguish between cable-based exercises (which need the Vitruvian trainer) and bodyweight exercises (which do not). When all exercises in a routine are bodyweight-only, the app should suppress device disconnect notifications since the trainer is not required.

Technical approach: Modify isWorkoutActiveForConnectionAlert in DefaultWorkoutSessionManager to return false when all exercises in the loaded routine are bodyweight-only. The Exercise.isBodyweight property already exists and is well-tested (Issue #635).

Effort: 3-5 hours (1 PR)

Key files:

• DefaultWorkoutSessionManager.kt — modify connection alert check
• BleConnectionManager.kt — optionally suppress auto-reconnect
• BleConnectionManagerTest.kt / MainViewModelTest.kt — add tests

Edge cases: Mixed routines (cable + bodyweight) will retain connection monitoring. Single exercise mode will check the current exercise's bodyweight flag.

Full assessment: feasibility.md

[9thLevelSoftware]

{
"body": "## Architecture Design: Suppress Device Disconnect During Bodyweight-Only Workouts\n\nRecommendation: Proceed to integration modelling.\n\nCore change: Modify isWorkoutActiveForConnectionAlert in DefaultWorkoutSessionManager.kt (line 474) to return false when all exercises in the loaded routine are bodyweight (routine.exercises.all { it.exercise.isBodyweight }).\n\nHow it works:\n- BleConnectionManager queries isWorkoutActiveForConnectionAlert at two points: the disconnect-alert path (line 131) and the auto-reconnect path (line 164). Returning false for bodyweight-only workouts suppresses both the ConnectionLostDialog and the auto-reconnect attempt in one place.\n- Mixed routines (cable + bodyweight) retain full connection monitoring.\n- Just Lift mode (no loaded routine) falls back to current behavior (alert fires — correct, since Just Lift uses the trainer).\n- Single Exercise mode creates a temp routine with one exercise, so the check works naturally.\n\nKey design decisions:\n1. Modify the existing property getter — single chokepoint, no interface change.\n2. All-exercises-bodyweight check (not per-exercise) — conservative, preserves alerts for mixed routines.\n3. No schema migration, no user setting, no feature flag — Exercise.isBodyweight already exists (Issue #635).\n4. Suppress alert + auto-reconnect together — they share the same gate.\n5. Fallback to true (alert fires) when routine is null or empty — safe direction.\n\nScope: ~80 lines across 3 files (1 source, 2 test). No UI, portal, or backend changes.\n\nEffort: ~4 hours, 1 PR.\n\nFull design: architecture.md in the enhancement artifacts."
}

[9thLevelSoftware]

Enhancement Review Request

Feature: Suppress device disconnect notifications during bodyweight-only workouts

Feasibility: ✅ ACCEPT — High-value, low-risk. Leverages existing Exercise.isBodyweight property. 3-5 hour implementation, 1 PR.

Architecture: Modify isWorkoutActiveForConnectionAlert in DefaultWorkoutSessionManager to return false when all exercises in the loaded routine are bodyweight. This suppresses both the ConnectionLostDialog and auto-reconnect in a single chokepoint. No interface changes, no schema migration, no UI changes.

Integration Model: Verified all claims against live source (HEAD d5c7691). ~70 LOC across 3 files (1 source, 2 test). No API/backend/portal changes.

Prototype: Not required — logic-only change, no visual surfaces affected.

Edge cases handled: Mixed routines retain full monitoring. Just Lift mode unchanged. Safe fallback when routine not loaded.

---

Next step: Please review and approve. React with 👍 or reply with approved / looks good / go ahead to approve. Reply with requested changes if you want modifications.

[9thLevelSoftware]

✅ Signoff Decision: APPROVED

Enhancement: Suppress Device Disconnect Notifications During Bodyweight-Only Workouts

Review Results

• Signoff Review (artifact consistency): PASS — All 3 artifacts consistent; 4 minor discrepancies (all refinements, no contradictions)
• Prototype Review (implementation validation): PASS — Architecture validated against live source at HEAD (62b914af)

Summary

Both reviews pass with no blocking issues. Enhancement is architecturally sound:

• Single chokepoint in DefaultWorkoutSessionManager.isWorkoutActiveForConnectionAlert
• Leverages existing Exercise.isBodyweight infrastructure
• No breaking changes (interface, schema, API, UI all unchanged)
• ~70-80 LOC across 3 files, single PR, ~4 hours

Next Step

Ready for implementation.

[9thLevelSoftware]

Implementation Plan

Enhancement: Suppress Device Disconnect Notifications During Bodyweight-Only Workouts
Status: Signoff-approved, ready for implementation

Scope

Single chokepoint modification: isWorkoutActiveForConnectionAlert in DefaultWorkoutSessionManager.kt returns false when all exercises in the loaded routine are bodyweight. This suppresses both the ConnectionLostDialog and BLE auto-reconnect for bodyweight-only workouts.

Files to Modify (3 files, ~70 LOC)

File	Change
DefaultWorkoutSessionManager.kt	Add bodyweight-only check to isWorkoutActiveForConnectionAlert getter (~10 LOC)
BleConnectionManagerTest.kt	Extend FakeWorkoutStateProvider with allBodyweight param; add unit test (~30 LOC)
MainViewModelTest.kt	Add integration test: bodyweight routine → disconnect → no alert (~30 LOC)

Key Design Decisions

• All-or-nothing: Alert suppressed only when ALL exercises are bodyweight. Mixed routines retain full monitoring.
• Safe fallback: Null/empty routine → alert fires (conservative).
• No UI changes: ConnectionLostDialog and EnhancedMainScreen unchanged.
• No schema migration: Uses existing Exercise.isBodyweight (Issue Exercise catalog: empty equipment on cable lifts makes isBodyweight unreliable #635).
• No feature flag: Pure improvement with no regression risk.

Non-Goals

• No user setting/toggle
• No per-exercise mid-routine switching
• No portal/backend changes
• No Just Lift bodyweight mode

Test Strategy

• Unit: BleConnectionManagerTest — bodyweight suppression + all existing regressions
• Integration: MainViewModelTest — full workout flow with bodyweight routine
• Manual QA: bodyweight, mixed, cable, single exercise, Just Lift scenarios

Full implementation spec and user instructions available in the enhancement artifact directory.

[9thLevelSoftware]

Implementation complete — PR #694 opened:

#694

Changes: Modified isWorkoutActiveForConnectionAlert in DefaultWorkoutSessionManager to suppress connection alerts when all routine exercises are bodyweight. ~91 LOC across 3 files. All tests green (unit + integration + regression).