Skip to content

Fix VeLa dialog scratch code not retained when closed without OK (#553)#575

Merged
dbenn merged 2 commits intomasterfrom
553-vela-dialog-content-not-retained-across-invocations
Apr 14, 2026
Merged

Fix VeLa dialog scratch code not retained when closed without OK (#553)#575
dbenn merged 2 commits intomasterfrom
553-vela-dialog-content-not-retained-across-invocations

Conversation

@dbenn
Copy link
Copy Markdown
Collaborator

@dbenn dbenn commented Apr 14, 2026

Persist editor text to the static cache in dispose() so Cancel and window close behave like dismiss, matching user expectation for the Tools -> VeLa scratch buffer.

Made-with: Cursor

Persist editor text to the static cache in dispose() so Cancel and window
close behave like dismiss, matching user expectation for the Tools -> VeLa
scratch buffer.

Made-with: Cursor
@dbenn dbenn self-assigned this Apr 14, 2026
@dbenn dbenn added bug Something isn't working VeLa VStar expression Language labels Apr 14, 2026
@dbenn dbenn linked an issue Apr 14, 2026 that may be closed by this pull request
@dbenn dbenn added the UI User Interface tuning label Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026

Plugin Unit Tests

All tests passed (Java 17)

Metric Value
Tests 1
Passed 1
Failures 0
Errors 0

@github-actions
Copy link
Copy Markdown
Contributor

SpotBugs Analysis

Priority Count
Total 621
High 58
Medium 563
Low 0
What does this mean?

SpotBugs performs static analysis on Java bytecode to find potential bugs.
High-priority findings are most likely to be real defects. Download the
spotbugs-report artifact for the detailed HTML report.

@github-actions
Copy link
Copy Markdown
Contributor

Checker Framework Nullness Analysis

Metric Count
Total warnings 1584
Nullness warnings 931
Initialization warnings 118
What does this mean?

The Checker Framework Nullness Checker verifies that the code is free from
null pointer dereferences. Warnings indicate places where a @Nullable value
may flow into a @NonNull context. Download the checker-framework-report
artifact for the full report.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026

VStar Unit Tests

All tests passed (Java 17)

Metric Value
Tests 750
Passed 750
Failures 0
Errors 0

- VStar and plugin workflows: drop coverage rows and artifact details from
  issue comments; keep tests/passed/failures/errors.
- SpotBugs and Checker Framework: remove PR issue comments (step summaries,
  artifacts, and gh-pages publishing unchanged).

Made-with: Cursor
@dbenn dbenn merged commit f8972eb into master Apr 14, 2026
20 checks passed
@dbenn dbenn deleted the 553-vela-dialog-content-not-retained-across-invocations branch April 14, 2026 14:17
@dbenn dbenn restored the 553-vela-dialog-content-not-retained-across-invocations branch April 14, 2026 14:23
@dbenn dbenn deleted the 553-vela-dialog-content-not-retained-across-invocations branch April 14, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI User Interface tuning VeLa VStar expression Language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VeLa dialog content not retained across invocations

1 participant