fix: correct function name grepCodeWithRipgrep -> grepCodeWithNativeRipgrep - #690
Merged
Merged
Conversation
…ipgrep In LinuxFileSystemTools.kt line 1176, grepCodeWithRipgrep was called but the actual function name is grepCodeWithNativeRipgrep (defined in StandardFileSystemTools.kt line 532). This typo was introduced in commit 181e4e3 (2026-03-11) and has been present in releases v1.10.0 through v1.12.0. Fixes AAswordman#688 Verified by CI: https://github.com/CATMIAOZHI/Operit/actions/runs/28904445796}
Collaborator
|
照aa所说 他忘add了 额 然后这个是19小时前的commit加的native rg，之前都是普通rg，考虑到你是first time我就给你融了 嗯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
grepCodeWithRipgrep→grepCodeWithNativeRipgrepProblem
LinuxFileSystemTools.kt:1176callsgrepCodeWithRipgrep(...), but this function does not exist. The actual function name isgrepCodeWithNativeRipgrep, defined inStandardFileSystemTools.kt:532.This causes a compile-time error — the project cannot be built from source.
Root Cause
Introduced in commit
181e4e37cc7d(2026-03-11,feat: replace grep with ripgrep). The same commit correctly wrotegrepCodeWithNativeRipgrepinStandardFileSystemTools.kt:4659but missed theNativeinLinuxFileSystemTools.kt:1176.Affected Versions
All 4 releases since 2026-03-11 are affected. The typo went unnoticed because the repository has no CI workflow to catch compile errors.
Fix
One-line change:
Verification
Compiled successfully via GitHub Actions CI:
./gradlew :app:assembleDebug -x lint --build-cacheRelated
Fixes #688