fix(market): preserve assets after registration failure - #896
Merged
Conversation
Remove destructive GitHub release rollback when market registration fails, and include the existing app version bump to 1.12.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明 / Description
修复插件市场登记失败后客户端删除 GitHub Release 或资产,导致已登记版本下载地址变成 404 的问题。
背景与动机 / Context and motivation
市场登记请求与 GitHub 资产操作不是同一事务。登记返回失败时,服务端可能已经完成写入;客户端继续回滚远端 Release/资产会破坏有效下载地址。
改动范围 / Changes
兼容性与风险 / Compatibility and risks
市场登记失败时会保留远端 Release/资产,便于重试,可能留下需要人工处理的孤立资源;不改变市场 API、资产格式或已成功发布资源的下载路径。
关联 Issue / Related issue
N/A:修复已确认的客户端发布回滚问题。
验证方式 / Verification
证据 / Evidence
已确认的事故链路为登记返回 version_conflict 后客户端删除同名 Release 资产;本 PR 删除该删除路径。
检查清单 / Checklist