Fix xenophobia in Creatures#4420
Merged
LtRipley36706 merged 1 commit intoACEmulator:masterfrom Mar 15, 2026
Merged
Conversation
Skip HeritageGroup checks during Activation/Use for Creatures
gmriggs
reviewed
Mar 15, 2026
Collaborator
gmriggs
left a comment
gmriggs
left a comment
There was a problem hiding this comment.
are you sure this code works as expected?
is this if check intended to fail for Creatures, but pass for Players? or is it intended to fail for both?
Member
Author
|
Yep, checked against NPCs and Vendors, while still maintaining the check for equipping or using other things that HeritageGroup defined. The check is skipped if the WorldObject being used is a Creature. |
gmriggs
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip HeritageGroup checks during Activation/Use for Creatures.
Thanks to Atanamir for catching this bug!