Enhance bitcoind checks during startup

[araspitzu]

Check the initialblockdownload flag from getblockchaininfo bitcoin RPC during startup, this is an additional check to ensure we're using a fully synced bitcoin instance.

[pm47]

Nice, find, if it works shouldn't we get rid of the verificationprogress > 0.999 check altogether?

[araspitzu]

Their meaning is almost overlapping but slightly different, the node is considered to be doing IBD whenever it has to download a large number of blocks (i.e for new nodes, or if it was offline for a long time), while the verification progress indicates at which point the verification is so far. There is a situation in which you haven't verified all the blocks but you're not technically in IBD

[codecov-io]

Codecov Report

Merging #1058 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1058      +/-   ##
==========================================
+ Coverage   82.06%   82.18%   +0.12%     
==========================================
  Files          99       99              
  Lines        7505     7507       +2     
  Branches      281      290       +9     
==========================================
+ Hits         6159     6170      +11     
+ Misses       1346     1337       -9

Impacted Files	Coverage Δ
...ir-core/src/main/scala/fr/acinq/eclair/Setup.scala	67.03% <100%> (+0.36%)	⬆️
...cala/fr/acinq/eclair/crypto/TransportHandler.scala	91.01% <0%> (-1.2%)	⬇️
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala	74.45% <0%> (-0.32%)	⬇️
...nq/eclair/blockchain/electrum/ElectrumClient.scala	72.65% <0%> (+0.37%)	⬆️
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala	97.05% <0%> (+3.92%)	⬆️
...clair/blockchain/electrum/ElectrumClientPool.scala	78.49% <0%> (+4.3%)	⬆️
...cinq/eclair/blockchain/bitcoind/zmq/ZMQActor.scala	94.87% <0%> (+5.12%)	⬆️
...lockchain/bitcoind/rpc/ExtendedBitcoinClient.scala	100% <0%> (+8.33%)	⬆️

[codecov-io]

Codecov Report

Merging #1058 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1058      +/-   ##
==========================================
+ Coverage   82.06%   82.18%   +0.12%     
==========================================
  Files          99       99              
  Lines        7505     7507       +2     
  Branches      281      290       +9     
==========================================
+ Hits         6159     6170      +11     
+ Misses       1346     1337       -9

Impacted Files	Coverage Δ
...ir-core/src/main/scala/fr/acinq/eclair/Setup.scala	67.03% <100%> (+0.36%)	⬆️
...cala/fr/acinq/eclair/crypto/TransportHandler.scala	91.01% <0%> (-1.2%)	⬇️
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala	74.45% <0%> (-0.32%)	⬇️
...nq/eclair/blockchain/electrum/ElectrumClient.scala	72.65% <0%> (+0.37%)	⬆️
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala	97.05% <0%> (+3.92%)	⬆️
...clair/blockchain/electrum/ElectrumClientPool.scala	78.49% <0%> (+4.3%)	⬆️
...cinq/eclair/blockchain/bitcoind/zmq/ZMQActor.scala	94.87% <0%> (+5.12%)	⬆️
...lockchain/bitcoind/rpc/ExtendedBitcoinClient.scala	100% <0%> (+8.33%)	⬆️