Conversation
This test was flaky because for the funding output, we provide two signatures, which means that we need twice the slack for the variable DER encoding length.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3299 +/- ##
==========================================
- Coverage 88.67% 88.64% -0.04%
==========================================
Files 221 222 +1
Lines 21453 21571 +118
Branches 832 868 +36
==========================================
+ Hits 19023 19121 +98
- Misses 2430 2450 +20 🚀 New features to boost your workflow:
|
pm47
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was flaky because for the funding output, we provide two signatures, which means that we need twice the slack for the variable DER encoding length.