GPT-OSS: Add user guide and tests - #2382
Conversation
4894858 to
c2ced34
Compare
4611c2e to
6570a4c
Compare
fafecfd to
7999c39
Compare
RissyRan
left a comment
There was a problem hiding this comment.
LGTM! Just a few minor comments
RissyRan
left a comment
There was a problem hiding this comment.
Could you also add announcement to the Main page to claim the support for gpt-oss models?
7999c39 to
c9f9cb2
Compare
I just updated "README.md" and "supported_models_and_architectures.md". |
c9f9cb2 to
a428827
Compare
|
🤖 Hi @shuningjin, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
📋 Review Summary
This pull request introduces support for the GPT-OSS family of models, including comprehensive user guides, test scripts, and necessary configuration updates. The changes are well-structured and the documentation is thorough.
🔍 General Feedback
- The addition of end-to-end test scripts for
gpt-oss-20bandgpt-oss-120bis excellent for ensuring model correctness and providing clear usage examples. - Several minor typos and path corrections in existing documentation have been addressed, improving overall quality.
- The validation logic added to
pyconfig.pyis a good proactive measure to prevent misconfiguration of the new models. - There were critical formatting errors in the new test scripts that would have caused them to fail. These have been highlighted in the inline comments.
322594b to
2a83b36
Compare
parambole
left a comment
There was a problem hiding this comment.
Thank you for adding this. I have left a few comments.
|
🤖 Hi @shuningjin, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Description
Main change: for gpt-oss
end_to_end/tpu/gpt_oss/run_gpt_oss.mdend_to_end/tpu/gpt_oss/20b/test_gpt_oss.shend_to_end/tpu/gpt_oss/120b/test_gpt_oss.shOther change: format output from forward_logit_checker, correct typos in other files
Tests
single script for tpu: checkpoint conversion, logit check, train, sft, decode (instead of splitting conversion to another)
gpt-oss-20b, end-to-end test on v5p-8 cluster, takes around 1h
The test will also be onboarded to XLML: GoogleCloudPlatform/ml-auto-solutions#913
Additional Notes
HF tokenizer:
HF access token:
Checklist
Before submitting this PR, please make sure (put X in square brackets):