Add decode check for Tunix SFT colab - #2386
Merged
Merged
Conversation
hengtaoguo
marked this pull request as ready for review
September 24, 2025 23:22
hengtaoguo
requested review from
A9isha,
NuojCheng,
RissyRan,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
vipannalla and
yangyuwei
as code owners
September 24, 2025 23:22
hengtaoguo
force-pushed
the
hengtaoguo-sft-validation
branch
2 times, most recently
from
September 25, 2025 04:15
15529fa to
097ddea
Compare
hengtaoguo
force-pushed
the
hengtaoguo-sft-validation
branch
from
September 25, 2025 22:08
0329b0e to
56a7539
Compare
SurbhiJainUSC
approved these changes
Sep 25, 2025
shralex
reviewed
Sep 29, 2025
A9isha
reviewed
Sep 30, 2025
A9isha
reviewed
Sep 30, 2025
hengtaoguo
force-pushed
the
hengtaoguo-sft-validation
branch
from
September 30, 2025 05:01
792b6a9 to
88df566
Compare
A9isha
approved these changes
Oct 8, 2025
hengtaoguo
force-pushed
the
hengtaoguo-sft-validation
branch
from
October 8, 2025 00:39
88df566 to
c6cd1f0
Compare
hengtaoguo
force-pushed
the
hengtaoguo-sft-validation
branch
5 times, most recently
from
October 8, 2025 05:03
95c4b82 to
1c873ac
Compare
hengtaoguo
force-pushed
the
hengtaoguo-sft-validation
branch
from
October 8, 2025 23:26
1c873ac to
08830db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a decode function to
vllm_decode.pyand its usage in Tunix SFT colab. We reuse the in-memory weights fromtrainer.modeland apply vllm inference framework to check the decoding results.Tests
Results from a 10-step Tunix SFT on llama3.1-8b:
Checklist
Before submitting this PR, please make sure (put X in square brackets):