remove redundant code block - #2393
Merged
Merged
Conversation
babyplutokurt
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
hengtaoguo,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
vipannalla and
yangyuwei
as code owners
September 24, 2025 22:00
RissyRan
approved these changes
Sep 24, 2025
RissyRan
left a comment
RissyRan
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
@richjames0 could you also help check if this is a typo or something? based on this PR.
hengtaoguo
approved these changes
Sep 24, 2025
Contributor
|
🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
📋 Review Summary
This pull request removes a redundant code block for handling local sliding attention within the tpu_flash_attention function. The change simplifies the code and improves readability without altering the underlying logic.
🔍 General Feedback
- The refactoring is clean and effectively removes unnecessary code.
- The logic for chunked attention is preserved and correctly integrated into the surrounding control flow.
4 tasks
babyplutokurt
force-pushed
the
fix_op_redundant
branch
from
September 26, 2025 17:39
4d05dbe to
dbf500a
Compare
RissyRan
reviewed
Sep 26, 2025
RissyRan
left a comment
RissyRan
left a comment
Collaborator
There was a problem hiding this comment.
2 approvers already from code owner, but no pull ready label added yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove redundant "Apply local masking if local sliding attention is enabled." check
Checklist
Before submitting this PR, please make sure (put X in square brackets):