Removing sequence from 'activation_vocab' sharding rule - #2505
Merged
copybara-service[bot] merged 2 commits intoOct 16, 2025
Conversation
Without this change, the automatic sharding resolution fails to pick up the correct sharding for activation_vocab when tensor_sequence is used.
abhinavgoel95
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
hengtaoguo,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
October 15, 2025 23:13
gobbleturk
approved these changes
Oct 16, 2025
gobbleturk
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Abhinav!
Apologies for our terribly complex rules, we have a fix in the works!! (eventaully...)
copybara-service
Bot
merged commit Oct 16, 2025
b959943
into
AI-Hypercomputer:main
25 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Without this change, the automatic sharding resolution fails to pick up the correct sharding for activation_vocab when tensor_sequence is used.
Removing sequence from 'activation_vocab' sharding rule
Tests
Tested Llama3 suite of models using tensor_sequence. Leads to 10% improvement in step time, because the vocab embedding GeMM now gets correct sharded.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.