Skip to content

Add zero-1 pyconfig rule - #2534

Merged
copybara-service[bot] merged 1 commit into
mainfrom
chengnuojin-zero1-fix
Oct 23, 2025
Merged

Add zero-1 pyconfig rule#2534
copybara-service[bot] merged 1 commit into
mainfrom
chengnuojin-zero1-fix

Conversation

@NuojCheng

Copy link
Copy Markdown
Collaborator

Description

Raise value error if opt_type is non-adam when zero-1 is enabled.

Tests

Standard MaxText tests

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@richjames0 richjames0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread src/MaxText/pyconfig.py Outdated
@NuojCheng
NuojCheng force-pushed the chengnuojin-zero1-fix branch from 388009f to c85153c Compare October 22, 2025 23:17
@NuojCheng
NuojCheng force-pushed the chengnuojin-zero1-fix branch from c85153c to 23147c9 Compare October 23, 2025 02:56
@copybara-service
copybara-service Bot merged commit 804ff4e into main Oct 23, 2025
27 checks passed
@copybara-service
copybara-service Bot deleted the chengnuojin-zero1-fix branch October 23, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants