Skip to content

Skip test_train_save_and_resume distillation unit test. - #4155

Merged
copybara-service[bot] merged 1 commit into
mainfrom
mohit/skip-distill-test
Jun 12, 2026
Merged

Skip test_train_save_and_resume distillation unit test.#4155
copybara-service[bot] merged 1 commit into
mainfrom
mohit/skip-distill-test

Conversation

@khatwanimohit

Copy link
Copy Markdown
Collaborator

This test hangs indefinitely when running on synthetic datasets because the loop termination check inside tunix library is skipped when is_managed_externally=True is configured.

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

CI

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

This test hangs indefinitely when running on synthetic datasets because the loop termination check inside `tunix` library is skipped when `is_managed_externally=True` is configured.

TAG=agy
CONV=1822511f-5517-44c5-8294-426243b7b179
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@copybara-service
copybara-service Bot merged commit a8505ff into main Jun 12, 2026
68 of 77 checks passed
@copybara-service
copybara-service Bot deleted the mohit/skip-distill-test branch June 12, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants