[DECOUPLED-MODE] grpo_trainer: route goodput/vertex imports through gcloud_stub for decoupled - #4180
Merged
copybara-service[bot] merged 1 commit intoJun 18, 2026
Conversation
…coupled mode (cherry picked from commit 8344887)
gulsumgudukbay
requested review from
A9isha,
NicoGrande,
darisoy,
gagika,
khatwanimohit,
richjames0,
shralex and
xuefgu
as code owners
June 16, 2026 20:32
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
darisoy
approved these changes
Jun 17, 2026
shralex
approved these changes
Jun 17, 2026
copybara-service
Bot
merged commit Jun 18, 2026
08f4eaf
into
AI-Hypercomputer:main
55 of 56 checks passed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The top-level
from ml_goodput_measurement.src.goodput import GoodputRecorderandfrom maxtext.common.vertex_tensorboard import VertexTensorboardManager(which pulls incloud_accelerator_diagnostics) hard-require cloud-only packages that are intentionally absent in decoupled environments (DECOUPLE_GCLOUD=TRUE). A single ModuleNotFoundError at import time aborted pytest collection for the whole suite (exit 2).Resolve both through the existing decoupled-aware paths, mirroring pre_train/train.py:
maxtext.common.goodput.goodputnamespace.gcloud_stub.vertex_tensorboard_modules().No behavior change when the real libraries are installed; decoupled runs fall back to the existing no-op stubs. Fixes rocm-decoupled collection (786/1157 collected, 371 deselected, exit 0).
Tests
Downstream CI decoupled ROCm run.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.