Use resolved mesh size for context parallel sharding - #4211
Merged
copybara-service[bot] merged 2 commits intoJun 26, 2026
Merged
Conversation
huytransformer
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
June 21, 2026 06:28
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
huytransformer
force-pushed
the
htn/context-parallel-size-from-mesh
branch
from
June 21, 2026 19:19
d86feae to
8ef48c9
Compare
NuojCheng
reviewed
Jun 22, 2026
huytransformer
force-pushed
the
htn/context-parallel-size-from-mesh
branch
from
June 22, 2026 17:39
8ef48c9 to
90e1d66
Compare
huytransformer
force-pushed
the
htn/context-parallel-size-from-mesh
branch
from
June 22, 2026 18:08
90e1d66 to
c722758
Compare
igorts-git
approved these changes
Jun 22, 2026
NuojCheng
approved these changes
Jun 25, 2026
huytransformer
force-pushed
the
htn/context-parallel-size-from-mesh
branch
from
June 26, 2026 02:31
2d13dcb to
84f4110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes TPU Flash/Tokamax Splash context-parallel sizing when
ici_context_parallelism=-1. This PR reads the context-parallel size from the mesh in the attention path and train setup.Tests
Ran TPU repro:
Checklist
gemini-reviewlabel.