Enable packing for all-gather CP - #4230
Merged
copybara-service[bot] merged 1 commit intoJun 25, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
huytransformer
marked this pull request as ready for review
June 24, 2026 19:22
huytransformer
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
June 24, 2026 19:22
igorts-git
approved these changes
Jun 24, 2026
richjames0
approved these changes
Jun 24, 2026
NuojCheng
reviewed
Jun 24, 2026
NuojCheng
reviewed
Jun 24, 2026
huytransformer
force-pushed
the
htn/ag-packing
branch
from
June 24, 2026 23:05
ea9a22b to
79394c0
Compare
copybara-service
Bot
merged commit Jun 25, 2026
a9963bc
into
AI-Hypercomputer:main
64 of 65 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, packed CP training was rejected unless
context_parallel_strategy="ring". The all-gather CP already has segment IDs and positions via the packed data, and TPU Flash attention already uses Q sharded over context with K/V gathered for attention.b/525146921
Tests
Ran TPU unit test:
Checklist
gemini-reviewlabel.