Add llama3.1-70b E2E test scripts - #4279
Conversation
98951f4 to
20a8cbb
Compare
e8ba9a7 to
04a50c4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
c3cb1b2 to
e4738b7
Compare
….1-70b Introduces E2E test configurations and scripts for llama3.1-70b model, covering both pre-training and post-training validation pipelines.
0f3682c to
6bf8e6f
Compare
| load_parameters_path=${CKPT_PATH} \ | ||
| base_output_directory=${BASE_OUTPUT_DIRECTORY}/to_huggingface/${scan_status}/${run_id} \ | ||
| use_multimodal=${USE_MULTIMODAL} \ | ||
| scan_layers=$SCAN_LAYERS No newline at end of file |
There was a problem hiding this comment.
should we do forward_pass_logit_checker as well?
There was a problem hiding this comment.
I'm not quite sure, as the existing tests/end_to_end/tpu/gemma3/4b/test_gemma3_to_hf.sh doesn't have this check. I followed its pattern for this PR.
| # export RUN_ID=$(date +%Y-%m-%d-%H-%M-%S) | ||
| # bash test_llama3.1_70b_to_mt.sh $RUN_ID | ||
| # bash test_llama3.1_70b_rl.sh $RUN_ID | ||
|
|
There was a problem hiding this comment.
$USE_PATHWAY is the second arguments?
There was a problem hiding this comment.
Yes, the second argument is for Pathways. But we don't need to manually pass it here since the DAG will automatically handle it and configure for us.
| set -ex | ||
|
|
||
| run_id=${1:-$(date +%Y-%m-%d-%H-%M-%S)} | ||
| use_pathways=${2:-false} |
There was a problem hiding this comment.
Should use_pathways to be true because we are testing with v5p cluster?
There was a problem hiding this comment.
We do need Pathways for multi-host VMs.
The reason we kept the default as false here is just for easier single-host/local testing. When running on multi-host through the DAG, the DAG will automatically pass true as the second argument to handle the Pathways setup for us.
| set -ex | ||
|
|
||
| run_id=${1:-$(date +%Y-%m-%d-%H-%M-%S)} | ||
| use_pathways=${2:-false} |
There was a problem hiding this comment.
Should use_pathways to be true if tested on multi-host vms?
There was a problem hiding this comment.
We do need Pathways for multi-host VMs.
The reason we kept the default as false here is just for easier single-host/local testing. When running on multi-host through the DAG, the DAG will automatically pass true as the second argument to handle the Pathways setup for us.
| # export HF_TOKEN=<your Hugging Face access token> | ||
| # export RUN_ID=$(date +%Y-%m-%d-%H-%M-%S) | ||
| # bash test_llama3.1_70b_to_mt.sh $RUN_ID | ||
| # bash test_llama3.1_70b_sft.sh $RUN_ID |
There was a problem hiding this comment.
Yes, the second argument is for Pathways. But we don't need to manually pass it here since the DAG will automatically handle it and configure for us.
4b357c1
into
AI-Hypercomputer:main
Description
This PR introduces end-to-end (E2E) testing and validation pipelines for the Llama3.1 70B model in MaxText.
Tests (Testing on v5p-128 cluster)
Pre-Training:
SFT:
RL:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.