Fix load-balanced TPU Splash masks#4298
Merged
copybara-service[bot] merged 1 commit intoJul 2, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
huytransformer
marked this pull request as ready for review
June 29, 2026 23:10
huytransformer
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
June 29, 2026 23:10
Shuwen-Fang
approved these changes
Jul 1, 2026
NuojCheng
reviewed
Jul 1, 2026
NuojCheng
approved these changes
Jul 1, 2026
gobbleturk
reviewed
Jul 1, 2026
gobbleturk
reviewed
Jul 1, 2026
gobbleturk
approved these changes
Jul 1, 2026
huytransformer
force-pushed
the
htn/tpu-splash-load-balanced-masks
branch
from
July 2, 2026 01:10
f561fc3 to
b4e0472
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes TPU Splash local sliding masks when CP load balancing is enabled. The causal mask already uses the load-balanced query order, but the local sliding mask used the default query order. This PR adds a load-balanced local mask so both masks use the same query positions.
BUGS: b/416110599
Tests
Ran:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.