Refactor DeepSeek MoE/Engram scanned decoder tests to use 3 layers#4312
Merged
Conversation
This avoids compilation OOM on TPU7x-8 slices by reducing the number of layers from 5 and 4 to 3. The skip guard for TPU7x is also removed.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
igorts-git
approved these changes
Jul 1, 2026
NuojCheng
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context:
Large rematerialized DeepSeek V4 MoE/Engram scanned decoder tests (
test_decoder_init_engram_2_8andtest_decoder_init_engram_4_9) experienced SPMD compilation buffer OOM crashes on 8-core TPU7x slices. This was due to memory pressure from unrolled chunks and workspace doubling on TPU7x (which lacks MegaCore, meaning 2 JAX devices share the same physical chip's HBM).Solution:
Refactored the tests to use
base_num_decoder_layers=3instead of5and4. This reduces the generated SPMD HLO graph size sufficiently to avoid OOM on TPU7x, while still validating the core scan-chunking compilation logic (Scan -> Engram -> Scan).Also removed the temporary skip guard that was bypassing these tests on TPU7x.
Bug: b/527535999
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.